On Mon, Jun 20, 2022 at 6:40 PM Jonathan Cameron <Jonathan.Cameron@xxxxxxxxxx> wrote: > On Mon, 20 Jun 2022 01:11:36 +0200 > Andy Shevchenko <andy.shevchenko@xxxxxxxxx> wrote: > > On Sun, Jun 19, 2022 at 8:59 PM Jonathan Cameron <jic23@xxxxxxxxxx> wrote: ... > > > drivers/iio/cdc/ad7746.c | 818 +++++++++++++++++++++++++++++++ > > > drivers/staging/iio/cdc/ad7746.c | 818 ------------------------------- > > > > It's a bit hard to review, perhaps you forgot to add -M -C when > > generating this patch? > > Specifically passed --no-renames because this is a direct file move - > I should have stated that though. > > The intent is to allow review of the full driver as being proposed for > move out of staging. In (my) practice it only makes review much harder without any additional benefits. Git is smart to understand renaming and in the diffstat there is a special line about renaming. > Including the bits that otherwise aren't > visible anywhere in the driver. I only do this (and ask for it from others) > for staging graduation patches. Perhaps somebody finds that useful, but me :-) -- With Best Regards, Andy Shevchenko
