> > Overall it looks good to me. One Q though, do you plan to switch it to > regmap APIs? Probably not unless doing some more significant work on the driver for some other reason. It's definitely not yet a requirement that IIO drivers use regmap, even though it is of course desirable where it fits well. Given it should be fine to do the conversion and rely on roadtest to see if anything isn't broken, converting this one might be a good first patch for someone who is interested in writing modern drivers. Thanks, Jonathan