On Mon, Jun 6, 2022 at 1:23 PM Dmitry Rokosov <DDRokosov@xxxxxxxxxxxxxx> wrote: > > As a part of patch series about wrong trigger register() and get() > calls order in the some IIO drivers trigger initialization path: > > https://lore.kernel.org/all/20220524181150.9240-1-ddrokosov@xxxxxxxxxxxxxx/ > > runtime WARN() is added to alarm IIO driver authors who make such > a mistake. > > When IIO driver allocates a new IIO trigger, it should register it before an IIO > calling the get() operation. In other words, each IIO driver must abide by > IIO trigger alloc()/register()/get() calls order. I believe triggers usually acquired at ->probe() time, means that in case if the following code (however, I believe it will be quite rare) goes into deferred probe cycle the WARN will be repeated. Perhaps WARN_ONCE() ? -- With Best Regards, Andy Shevchenko
