On Fri, 13 May 2022 02:40:41 +0300 Dmitry Osipenko <digetx@xxxxxxxxx> wrote: > Hello Shreeya, > > ... > > +#include <linux/init.h> > > +#include <linux/mod_devicetable.h> > > You may safely remove these includes because module.h always provides them. Safely yes, but generally I'd prefer direct include of mod_devicetable.h because of the direct use of elements from it in the driver. Jonathan