On Tue, 10 May 2022 14:17:51 +0000
LI Qingwu <Qing-wu.Li@xxxxxxxxxxxxxxxxxxxxxxx> wrote:
> Add supports for BMI085, an Inertial Measurement Unit,
> with an accelerometer and gyroscope.
> The commit adds the accelerometer driver for the SPI interface.
> The gyroscope part is already supported by the BMG160 driver.
> Different from BMI088, the BMI085 accelerometer has the range of
> +/-2, 4, 6, and 8g.
>
> Reviewed-by: Alexandru Ardelean <ardeleanalex@xxxxxxxxx>
> Signed-off-by: LI Qingwu <Qing-wu.Li@xxxxxxxxxxxxxxxxxxxxxxx>
Hi,
A request to change the ordering of id table entries below.
> ---
> drivers/iio/accel/bmi088-accel-core.c | 7 +++++++
> drivers/iio/accel/bmi088-accel-spi.c | 1 +
> 2 files changed, 8 insertions(+)
>
> diff --git a/drivers/iio/accel/bmi088-accel-core.c b/drivers/iio/accel/bmi088-accel-core.c
> index de2385e4dad5..13bb3d96a3a6 100644
> --- a/drivers/iio/accel/bmi088-accel-core.c
> +++ b/drivers/iio/accel/bmi088-accel-core.c
> @@ -465,6 +465,13 @@ static const struct bmi088_accel_chip_info bmi088_accel_chip_info_tbl[] = {
> .num_channels = ARRAY_SIZE(bmi088_accel_channels),
> .scale_table = {{0, 897}, {0, 1795}, {0, 3590}, {0, 7179}},
> },
> + [1] = {
> + .name = "bmi085-accel",
> + .chip_id = 0x1F,
Probably makes sense to keep these entries in order of chip_id - so leave the
order as you have it for this array.
> + .channels = bmi088_accel_channels,
> + .num_channels = ARRAY_SIZE(bmi088_accel_channels),
> + .scale_table = {{0, 598}, {0, 1196}, {0, 2393}, {0, 4785}},
> + },
> };
>
> static const struct iio_info bmi088_accel_info = {
> diff --git a/drivers/iio/accel/bmi088-accel-spi.c b/drivers/iio/accel/bmi088-accel-spi.c
> index 0fed0081e1fd..e7a1daab8f3c 100644
> --- a/drivers/iio/accel/bmi088-accel-spi.c
> +++ b/drivers/iio/accel/bmi088-accel-spi.c
> @@ -61,6 +61,7 @@ static int bmi088_accel_remove(struct spi_device *spi)
>
> static const struct spi_device_id bmi088_accel_id[] = {
> {"bmi088-accel", },
> + {"bmi085-accel", },
Alphabetical / numeric order preferred.
> {}
> };
> MODULE_DEVICE_TABLE(spi, bmi088_accel_id);
