On Sat, 14 May 2022 15:04:32 +0200 Uwe Kleine-König <u.kleine-koenig@xxxxxxxxxxxxxx> wrote: > Returning an error value in an i2c remove callback results in an error > message being emitted by the i2c core, but otherwise it doesn't make a > difference. > > As afe4404_remove() already emits an error message on failure and the > additional error message by the i2c core doesn't add any useful > information, change the return value to zero to suppress this message. > > This patch is a preparation for making i2c remove callbacks return void. > > Signed-off-by: Uwe Kleine-König <u.kleine-koenig@xxxxxxxxxxxxxx> Applied. Like the others this will sit in testing until I can rebase the togreg branch. Thanks, Jonathan > --- > Hello, > > this is similar to the patches I sent recently. > (https://lore.kernel.org/linux-iio/20220430081607.15078-1-u.kleine-koenig@xxxxxxxxxxxxxx/) > Just missed this driver when I intended to address this problem type for > all of drivers/iio/. > > Best regards > Uwe > > drivers/iio/health/afe4404.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/drivers/iio/health/afe4404.c b/drivers/iio/health/afe4404.c > index aa9311e1e655..1bb7de60f8ca 100644 > --- a/drivers/iio/health/afe4404.c > +++ b/drivers/iio/health/afe4404.c > @@ -591,10 +591,8 @@ static int afe4404_remove(struct i2c_client *client) > iio_trigger_unregister(afe->trig); > > ret = regulator_disable(afe->regulator); > - if (ret) { > + if (ret) > dev_err(afe->dev, "Unable to disable regulator\n"); > - return ret; > - } > > return 0; > } > > base-commit: 3123109284176b1532874591f7c81f3837bbdc17
