Hi Biju,
On Wed, May 11, 2022 at 9:04 AM Biju Das <biju.das.jz@xxxxxxxxxxxxxx> wrote:
> Document Renesas RZ/G2UL ADC bindings. RZ/G2UL ADC is almost identical
> to RZ/G2L, but it has 2 analog input channels compared to 8 channels
> on the RZ/G2L.
>
> Signed-off-by: Biju Das <biju.das.jz@xxxxxxxxxxxxxx>
> ---
> v2->v3:
> * Added generic description for reg.
> * Improved schema validation by restricting both channel and reg to [0-1].
Thanks for the update!
> --- a/Documentation/devicetree/bindings/iio/adc/renesas,rzg2l-adc.yaml
> +++ b/Documentation/devicetree/bindings/iio/adc/renesas,rzg2l-adc.yaml
> @@ -19,6 +19,7 @@ properties:
> compatible:
> items:
> - enum:
> + - renesas,r9a07g043-adc # RZ/G2UL
> - renesas,r9a07g044-adc # RZ/G2L
> - renesas,r9a07g054-adc # RZ/V2L
> - const: renesas,rzg2l-adc
> @@ -76,16 +77,43 @@ patternProperties:
> properties:
> reg:
> description: |
> - The channel number. It can have up to 8 channels numbered from 0 to 7.
> - items:
> - - minimum: 0
> - maximum: 7
> + The channel number.
>
> required:
> - reg
>
> additionalProperties: false
>
> +allOf:
> + - if:
> + properties:
> + compatible:
> + contains:
> + const: renesas,r9a07g043-adc
> + then:
> + patternProperties:
> + "^channel@[2-7]$": false
> + "^channel@[0-1]$":
> + type: object
> + properties:
> + reg:
> + description: |
> + It can have up to 2 channels numbered from 0 to 1.
IMHO the description doesn't add any value, as it's equivalent to
the logic below.
> + items:
I don't think the "items" is needed or wanted, as there can be
only one?
> + - minimum: 0
> + maximum: 1
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
