Re: [PATCH 78/92] iio: imu: icm42600: Fix alignment for DMA safety in buffer code.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Acked-by: Jean-Baptiste Maneyrol <jean-baptiste.maneyrol@xxxxxxx>


From: Jonathan Cameron <jic23@xxxxxxxxxx>
Sent: Tuesday, May 3, 2022 10:59
To: linux-iio@xxxxxxxxxxxxxxx <linux-iio@xxxxxxxxxxxxxxx>
Cc: Akinobu Mita <akinobu.mita@xxxxxxxxx>; Alexandru Lazar <alazar@xxxxxxxxxxxxx>; Alexandru Tachici <alexandru.tachici@xxxxxxxxxx>; Antoniu Miclaus <antoniu.miclaus@xxxxxxxxxx>; Charles-Antoine Couret <charles-antoine.couret@xxxxxxxxxxxxx>; Cosmin Tanislav <cosmin.tanislav@xxxxxxxxxx>; Cristian Pop <cristian.pop@xxxxxxxxxx>; David Lechner <david@xxxxxxxxxxxxxx>; Ivan Mikhaylov <i.mikhaylov@xxxxxxxxx>; Jacopo Mondi <jacopo+renesas@xxxxxxxxxx>; Jean-Baptiste Maneyrol <jmaneyrol@xxxxxxxxxxxxxx>; Lars-Peter Clausen <lars@xxxxxxxxxx>; Marcelo Schmitt <marcelo.schmitt1@xxxxxxxxx>; Mårten Lindahl <martenli@xxxxxxxx>; Matt Ranostay <mranostay@xxxxxxxxx>; Michael Hennerich <michael.hennerich@xxxxxxxxxx>; Michael Welling <mwelling@xxxxxxxx>; Mugilraj Dhavachelvan <dmugil2000@xxxxxxxxx>; Navin Sankar Velliangiri <navin@xxxxxxxxxxx>; Nuno Sá <nuno.sa@xxxxxxxxxx>; Paul Cercueil <paul@xxxxxxxxxxxxxxx>; Phil Reid <preid@xxxxxxxxxxxxxxxxx>; Puranjay Mohan <puranjay12@xxxxxxxxx>; Ricardo Ribalda <ribalda@xxxxxxxxxx>; Robert Jones <rjones@xxxxxxxxxxxxx>; Rui Miguel Silva <rui.silva@xxxxxxxxxx>; Sean Nyekjaer <sean.nyekjaer@xxxxxxxxx>; Tomas Melin <tomas.melin@xxxxxxxxxxx>; Tomislav Denis <tomislav.denis@xxxxxxx>; Uwe Kleine-König <u.kleine-koenig@xxxxxxxxxxxxxx>; Jonathan Cameron <Jonathan.Cameron@xxxxxxxxxx>
Subject: [PATCH 78/92] iio: imu: icm42600: Fix alignment for DMA safety in buffer code. 
 
[CAUTION] This is EXTERNAL email. Do not click any links or open attachments unless you recognize the sender and know the content is safe.

======================================================================
From: Jonathan Cameron <Jonathan.Cameron@xxxxxxxxxx>

Second fix for this driver due to different introducing patches.

____cacheline_aligned is an insufficient guarantee for non-coherent DMA
on platforms with 128 byte cachelines above L1.  Switch to the updated
IIO_ALIGN definition.

Fixes: 7f85e42a6c54 ("iio: imu: inv_icm42600: add buffer support in iio devices")
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@xxxxxxxxxx>
Cc: Jean-Baptiste Maneyrol <jmaneyrol@xxxxxxxxxxxxxx>
---
 drivers/iio/imu/inv_icm42600/inv_icm42600_buffer.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/iio/imu/inv_icm42600/inv_icm42600_buffer.h b/drivers/iio/imu/inv_icm42600/inv_icm42600_buffer.h
index de2a3949dcc7..56545638bfcd 100644
--- a/drivers/iio/imu/inv_icm42600/inv_icm42600_buffer.h
+++ b/drivers/iio/imu/inv_icm42600/inv_icm42600_buffer.h
@@ -39,7 +39,7 @@ struct inv_icm42600_fifo {
                 size_t accel;
                 size_t total;
         } nb;
-       uint8_t data[2080] ____cacheline_aligned;
+       uint8_t data[2080] __aligned(IIO_ALIGN);
 };
 
 /* FIFO data packet */
-- 
2.36.0




[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Input]     [Linux Kernel]     [Linux SCSI]     [X.org]

  Powered by Linux