Re: [PATCH 77/92] iio: imu_icm42600: Fix alignment for DMA safety

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Acked-by: Jean-Baptiste Maneyrol <jean-baptiste.maneyrol@xxxxxxx>


From: Jonathan Cameron <jic23@xxxxxxxxxx>
Sent: Tuesday, May 3, 2022 10:59
To: linux-iio@xxxxxxxxxxxxxxx <linux-iio@xxxxxxxxxxxxxxx>
Cc: Akinobu Mita <akinobu.mita@xxxxxxxxx>; Alexandru Lazar <alazar@xxxxxxxxxxxxx>; Alexandru Tachici <alexandru.tachici@xxxxxxxxxx>; Antoniu Miclaus <antoniu.miclaus@xxxxxxxxxx>; Charles-Antoine Couret <charles-antoine.couret@xxxxxxxxxxxxx>; Cosmin Tanislav <cosmin.tanislav@xxxxxxxxxx>; Cristian Pop <cristian.pop@xxxxxxxxxx>; David Lechner <david@xxxxxxxxxxxxxx>; Ivan Mikhaylov <i.mikhaylov@xxxxxxxxx>; Jacopo Mondi <jacopo+renesas@xxxxxxxxxx>; Jean-Baptiste Maneyrol <jmaneyrol@xxxxxxxxxxxxxx>; Lars-Peter Clausen <lars@xxxxxxxxxx>; Marcelo Schmitt <marcelo.schmitt1@xxxxxxxxx>; Mårten Lindahl <martenli@xxxxxxxx>; Matt Ranostay <mranostay@xxxxxxxxx>; Michael Hennerich <michael.hennerich@xxxxxxxxxx>; Michael Welling <mwelling@xxxxxxxx>; Mugilraj Dhavachelvan <dmugil2000@xxxxxxxxx>; Navin Sankar Velliangiri <navin@xxxxxxxxxxx>; Nuno Sá <nuno.sa@xxxxxxxxxx>; Paul Cercueil <paul@xxxxxxxxxxxxxxx>; Phil Reid <preid@xxxxxxxxxxxxxxxxx>; Puranjay Mohan <puranjay12@xxxxxxxxx>; Ricardo Ribalda <ribalda@xxxxxxxxxx>; Robert Jones <rjones@xxxxxxxxxxxxx>; Rui Miguel Silva <rui.silva@xxxxxxxxxx>; Sean Nyekjaer <sean.nyekjaer@xxxxxxxxx>; Tomas Melin <tomas.melin@xxxxxxxxxxx>; Tomislav Denis <tomislav.denis@xxxxxxx>; Uwe Kleine-König <u.kleine-koenig@xxxxxxxxxxxxxx>; Jonathan Cameron <Jonathan.Cameron@xxxxxxxxxx>
Subject: [PATCH 77/92] iio: imu_icm42600: Fix alignment for DMA safety 
 
[CAUTION] This is EXTERNAL email. Do not click any links or open attachments unless you recognize the sender and know the content is safe.

======================================================================
From: Jonathan Cameron <Jonathan.Cameron@xxxxxxxxxx>

Partial fix for this driver as a second instance was introduced in
a later patch.

____cacheline_aligned is an insufficient guarantee for non-coherent DMA
on platforms with 128 byte cachelines above L1.  Switch to the updated
IIO_ALIGN definition.

Fixes: a095fadb443b ("iio: imu: inv_icm42600: add gyroscope IIO device")
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@xxxxxxxxxx>
Cc: Jean-Baptiste Maneyrol <jmaneyrol@xxxxxxxxxxxxxx>
---
 drivers/iio/imu/inv_icm42600/inv_icm42600.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/iio/imu/inv_icm42600/inv_icm42600.h b/drivers/iio/imu/inv_icm42600/inv_icm42600.h
index c0f5059b13b3..5b3740cb364f 100644
--- a/drivers/iio/imu/inv_icm42600/inv_icm42600.h
+++ b/drivers/iio/imu/inv_icm42600/inv_icm42600.h
@@ -140,7 +140,7 @@ struct inv_icm42600_state {
         struct inv_icm42600_suspended suspended;
         struct iio_dev *indio_gyro;
         struct iio_dev *indio_accel;
-       uint8_t buffer[2] ____cacheline_aligned;
+       uint8_t buffer[2] __aligned(IIO_ALIGN);
         struct inv_icm42600_fifo fifo;
         struct {
                 int64_t gyro;
-- 
2.36.0




[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Input]     [Linux Kernel]     [Linux SCSI]     [X.org]

  Powered by Linux