On Wed, Apr 13, 2022 at 03:38:47PM +0000, Sa, Nuno wrote: > > From: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx> > > Sent: Wednesday, April 13, 2022 4:41 PM > > The extended clocks are optional and may not be present for some > > SoCs > > supported by this driver. Nevertheless, in case the clock is provided > > but some error happens during its getting, that error should be > > handled > > properly. Use devm_clk_get_optional() API for that. Also report > > possible > > errors using dev_err_probe() to handle properly -EPROBE_DEFER > > error. > This is a nice cleanup patch... But the subject might be a bit > misleading as it says "Fix". So I would expect a Fixes tag which > I'm not sure it's really worth it here. Yes, the code was pretty much > doing clk_get_optional() "by hand" but I think it was still functional. > So to me, this is more an improvement rather than a fix... Actually it is a fix, but not critical since no-one complains aloud so far. The problematic part is logs exhausting if repetitive deferred probe happens. > Anyways, > > Reviewed-by: Nuno Sá <nuno.sa@xxxxxxxxxx> Thanks! -- With Best Regards, Andy Shevchenko
