> From: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx> > Sent: Wednesday, April 13, 2022 4:41 PM > To: Sa, Nuno <Nuno.Sa@xxxxxxxxxx>; Andy Shevchenko > <andriy.shevchenko@xxxxxxxxxxxxxxx>; linux-iio@xxxxxxxxxxxxxxx; > linux-kernel@xxxxxxxxxxxxxxx > Cc: Lars-Peter Clausen <lars@xxxxxxxxxx>; Hennerich, Michael > <Michael.Hennerich@xxxxxxxxxx>; Jonathan Cameron > <jic23@xxxxxxxxxx> > Subject: [PATCH v1 3/3] iio: imu: adis16480: Fix getting the optional > clocks > > [External] > > The extended clocks are optional and may not be present for some > SoCs > supported by this driver. Nevertheless, in case the clock is provided > but some error happens during its getting, that error should be > handled > properly. Use devm_clk_get_optional() API for that. Also report > possible > errors using dev_err_probe() to handle properly -EPROBE_DEFER > error. > > Signed-off-by: Andy Shevchenko > <andriy.shevchenko@xxxxxxxxxxxxxxx> > --- This is a nice cleanup patch... But the subject might be a bit misleading as it says "Fix". So I would expect a Fixes tag which I'm not sure it's really worth it here. Yes, the code was pretty much doing clk_get_optional() "by hand" but I think it was still functional. So to me, this is more an improvement rather than a fix... Anyways, Reviewed-by: Nuno Sá <nuno.sa@xxxxxxxxxx>
