On 3/21/22 17:19, Andy Shevchenko wrote:
On Mon, Mar 21, 2022 at 03:44:24PM +0100, Marek Vasut wrote:
On 3/21/22 10:27, Andy Shevchenko wrote:
On Sun, Mar 20, 2022 at 8:14 PM Marek Vasut <marex@xxxxxxx> wrote:
...
+static const int ads1015_fullscale_range[] = {
6144, 4096, 2048, 1024, 512, 256, 256, 256
Keep a comma at the end.
Also applies to the rest of the modified data structures below.
Why ? We don't expect these arrays to grow new values, if there is ever some
new ADC, it will likely have its own array.
Just for the sake of a common style. But it's not critical,
so I leave it to the maintainers.
The common style of the other arrays in that driver is without a
trailing comma, hence the way it is right now is the common style.
I do however understand the rationale why a trailing comma in structures
makes sense (you don't have to add it in some subsequent patch, which
does only cause churn and unrelated line changes), but I don't think
that applies in this particular case.
