On Mon, Feb 07, 2022 at 08:44:21PM +0000, Jonathan Cameron wrote: > On Mon, 7 Feb 2022 19:21:25 +0200 > Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx> wrote: > > > On Mon, Feb 07, 2022 at 08:37:55AM -0800, Joe Perches wrote: > > > On Mon, 2022-02-07 at 12:48 +0200, Andy Shevchenko wrote: > > > > In a couple of messages the constants, which have their definitions, > > > > are hard coded into the message text. Unhardcode them. > > > > > > Found by inspection or tool? > > > > Does it matter? No, a side effect of the following patch. > > > > ... > > > > > > + dev_err(dev, "Steinhart sensors size(%zu) must be %d", new_custom->size, > > > > + LTC2983_CUSTOM_STEINHART_SIZE); > > > > > > probably better using "%u" and not "%d" > > > > > > and better with a \n termination too. > > > > I think it would be a separate change if we wish so. Let Jonathan to tell what > > to do here. > > > Either way is fine by me. I tend to be a little flexible of trivial fixes > in patches that are as simple as this one. v3 has been just sent. -- With Best Regards, Andy Shevchenko
