On Mon, 2022-02-07 at 12:48 +0200, Andy Shevchenko wrote:
> In a couple of messages the constants, which have their definitions,
> are hard coded into the message text. Unhardcode them.
Found by inspection or tool?
> diff --git a/drivers/iio/temperature/ltc2983.c b/drivers/iio/temperature/ltc2983.c
[]
> @@ -409,8 +409,8 @@ static struct ltc2983_custom_sensor *__ltc2983_custom_sensor_new(
> new_custom->size = n_entries * n_size;
> /* check Steinhart size */
> if (is_steinhart && new_custom->size != LTC2983_CUSTOM_STEINHART_SIZE) {
> - dev_err(dev, "Steinhart sensors size(%zu) must be 24",
> - new_custom->size);
> + dev_err(dev, "Steinhart sensors size(%zu) must be %d", new_custom->size,
> + LTC2983_CUSTOM_STEINHART_SIZE);
probably better using "%u" and not "%d"
and better with a \n termination too.
> return ERR_PTR(-EINVAL);
> }
> /* Check space on the table. */
> @@ -1299,8 +1299,8 @@ static int ltc2983_parse_dt(struct ltc2983_data *st)
> if (sensor.chan < LTC2983_MIN_CHANNELS_NR ||
> sensor.chan > LTC2983_MAX_CHANNELS_NR) {
> ret = -EINVAL;
> - dev_err(dev,
> - "chan:%d must be from 1 to 20\n", sensor.chan);
> + dev_err(dev, "chan:%d must be from %d to %d\n", sensor.chan,
> + LTC2983_MIN_CHANNELS_NR, LTC2983_MAX_CHANNELS_NR);
> goto put_child;
> } else if (channel_avail_mask & BIT(sensor.chan)) {
> ret = -EINVAL;
