On Sat, 5 Feb 2022 23:31:21 -0300 Marcelo Schmitt <marcelo.schmitt1@xxxxxxxxx> wrote: > On 01/30, Jonathan Cameron wrote: > > On Sat, 18 Dec 2021 18:18:12 -0300 > > Marcelo Schmitt <marcelo.schmitt1@xxxxxxxxx> wrote: > > > > > Think it would be more intuitive to use the number of active channels as enum > > > elements for adi,temp-alert-last-chan and adi,voltage-alert-last-chan. > > > > Just to check I understand correctly, you mean active number of channels > > across all devices, or just in the last device? > > I was thinking about the number of channels enabled for alert detection only in > the last device. > For voltage inputs, we would have 6, 5, or 4 channels enabled. So the possible > values for adi,voltage-alert-last-chan would be [4, 5, 6], default: 6. > For temperature inputs, things get a bit hairy. > * We may have all 6 AUX enabled. > * We may have 3 AUX enabled if D15:D14 = 01 in the control register. If so, we still may: > + disable AUX5, or > + disable AUX5 and AUX3 > So the possibilities for adi,temp-alert-last-chan would be 1, 2, 3, or 6 AUX > channels enabled for alert detection. Glad I just dropped support for that ;) For the voltage one I'm going to leave it as adi,voltage-alert-last-chan because I'm not sure what naming would work if we changed it to number supported because it feels like adi,voltage-alert-last-num-chan is weird and I don't want complexity of adi,voltage-alert-num-chans as that would have to include the channels on previous devices and if we ever support the 1,3,5 mode the two will couple in a horrible fashion.
