Think it would be more intuitive to use the number of active channels as enum elements for adi,temp-alert-last-chan and adi,voltage-alert-last-chan. This, though, is just my personal opinion so Reviewed-by: Marcelo Schmitt <marcelo.schmitt1@xxxxxxxxx> On 12/05, Jonathan Cameron wrote: > From: Jonathan Cameron <Jonathan.Cameron@xxxxxxxxxx> > > Add a binding for this Lithium Ion Battery monitoring chip/chain of chips > as it is now clean and ready to move out of staging. > > Signed-off-by: Jonathan Cameron <Jonathan.Cameron@xxxxxxxxxx> > Reviewed-by: Rob Herring <robh@xxxxxxxxxx> > --- > .../bindings/iio/adc/adi,ad7280a.yaml | 87 +++++++++++++++++++ > 1 file changed, 87 insertions(+) > > diff --git a/Documentation/devicetree/bindings/iio/adc/adi,ad7280a.yaml b/Documentation/devicetree/bindings/iio/adc/adi,ad7280a.yaml > new file mode 100644 > index 000000000000..77b8f67fe446 > --- /dev/null > +++ b/Documentation/devicetree/bindings/iio/adc/adi,ad7280a.yaml > @@ -0,0 +1,87 @@ > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/iio/adc/adi,ad7280a.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Analog Devices AD7280a Lithium Ion Battery Monitoring System > + > +maintainers: > + - Michael Hennerich <michael.hennerich@xxxxxxxxxx> > + - Jonathan Cameron <jic23@xxxxxxxxxx> > + > +description: | > + Bindings for the Analog Devices AD7280a Battery Monitoring System. > + Used in devices such as hybrid electric cars, battery backup and power tools. > + Multiple chips can be daisy chained and accessed via a single SPI interface. > + Data sheet found here: > + https://www.analog.com/media/en/technical-documentation/data-sheets/AD7280A.pdf > + > +properties: > + compatible: > + const: adi,ad7280a > + > + reg: > + maxItems: 1 > + > + interrupts: > + description: IRQ line for the ADC > + maxItems: 1 > + > + spi-max-frequency: true > + > + adi,temp-alert-last-chan: > + $ref: /schemas/types.yaml#/definitions/uint32 > + description: > + Allows limiting of scope of which channels are considered for temperature > + alerts, typically because not all are wired to anything. Only applies to > + last device in the daisy chain. > + default: 5 > + enum: [3, 4, 5] > + > + adi,voltage-alert-last-chan: > + $ref: /schemas/types.yaml#/definitions/uint32 > + description: > + Allows limiting of scope of which channels are considered for voltage > + alerts, typically because not all are wired to anything. Only applies to > + last device in the daisy chain. > + default: 5 > + enum: [3, 4, 5] > + > + adi,acquisition-time-ns: > + description: > + Additional time may be needed to charge the sampling capacitors depending > + on external writing. > + default: 400 > + enum: [400, 800, 1200, 1600] > + > + adi,thermistor-termination: > + type: boolean > + description: > + Enable the thermistor termination function. > + > +required: > + - compatible > + - reg > + > +additionalProperties: false > + > +examples: > + - | > + spi { > + #address-cells = <1>; > + #size-cells = <0>; > + > + adc@0 { > + compatible = "adi,ad7280a"; > + reg = <0>; > + spi-max-frequency = <700000>; > + interrupt-parent = <&gpio>; > + interrupts = <25 2>; > + adi,thermistor-termination; > + adi,acquisition-time-ns = <800>; > + adi,voltage-alert-last-chan = <5>; > + adi,temp-alert-last-chan = <5>; > + }; > + }; > +... > -- > 2.34.1 >
