On Thu, Jan 27, 2022 at 6:22 PM Andy Shevchenko <andy.shevchenko@xxxxxxxxx> wrote: > On Thu, Jan 27, 2022 at 4:38 PM Kai-Heng Feng > <kai.heng.feng@xxxxxxxxxxxxx> wrote: ... > > +static const struct acpi_device_id dps310_acpi_match[] = { > > + { "IFX3100" }, > > + { }, And no comma needed here. > > +}; > > > + > > This is redundant, I hope Jonathan may remove it when applying. > > > +MODULE_DEVICE_TABLE(acpi, dps310_acpi_match); -- With Best Regards, Andy Shevchenko