Re: [PATCH v2 01/51] iio:accel:da311: Switch from CONFIG_PM_SLEEP guards to pm_sleep_ptr() etc

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Jan 4, 2022 at 10:08 AM Paul Cercueil <paul@xxxxxxxxxxxxxxx> wrote:
> Le mar., janv. 4 2022 at 14:16:01 +0000, Jonathan Cameron
> >
> > Paul, over to you for reasoning.  If we are going to change this
> > now is the time before they get significant use and we end up having
> > to add static to lots of places.
>
> I have an idea on how to tackle automatic dead code removal on exported
> dev_pm_ops symbols. It means introducing a separate
> EXPORTED_SIMPLE_DEV_PM_OPS(), so the current DEFINE_SIMPLE_DEV_PM_OPS()
> macro could keep the "static". Unless you still think it's a bad idea,
> then in this case we can remove it.

I would prefer removing the implicit 'static' if only for consistency reasons,
which to me outweighs the simplicity aspect in this case.

         Arnd



[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Input]     [Linux Kernel]     [Linux SCSI]     [X.org]

  Powered by Linux