On Sun, Jan 2, 2022 at 7:55 AM Jonathan Cameron <jic23@xxxxxxxxxx> wrote: > > -static SIMPLE_DEV_PM_OPS(da311_pm_ops, da311_suspend, da311_resume); > +DEFINE_SIMPLE_DEV_PM_OPS(da311_pm_ops, da311_suspend, da311_resume); > Does the new DEFINE_SIMPLE_DEV_PM_OPS imply 'static'? I see that you remove the specifier in all the patches, which would not work otherwise, but I wonder what that means for drivers that actually define the pm-ops globally on purpose and can't do that any more after the conversion. Arnd