On Fri, Dec 17, 2021 at 10:17:58AM +0100, Lars-Peter Clausen wrote: > On 12/17/21 10:05 AM, Jacopo Mondi wrote: > > Hi Lars-Peter, > > > > On Thu, Dec 16, 2021 at 07:52:14PM +0100, Lars-Peter Clausen wrote: > > > sysfs_emit() is preferred over raw s*printf() for sysfs attributes since it > > > knows about the sysfs buffer specifics and has some built-in checks for > > > size and alignment. > > > > > > Use sysfs_emit() to format the custom `in_power_shunt_resistor` and > > > `in_current_shunt_resistor` device attributes of the max9611 driver. > > > > > > Signed-off-by: Lars-Peter Clausen <lars@xxxxxxxxxx> > > Looks good, I just wonder if a dependency on the CONFIG_SYSFS symbol > > should now be added... > > > I don't think anything has changed in this regard. The function is called > from a sysfs attribute callback. If SYSFS is disabled the callback will not > be called. At the same time sysfs_emit() is stubbed out when SYSFS is > disabled, so no compile error either. You're right, nothing changes, we won't have any attribute to call the function on :) Reviewed-by: Jacopo Mondi <jacopo+renesas@xxxxxxxxxx> Thanks! j
