Hi Lars-Peter, On Thu, Dec 16, 2021 at 07:52:14PM +0100, Lars-Peter Clausen wrote: > sysfs_emit() is preferred over raw s*printf() for sysfs attributes since it > knows about the sysfs buffer specifics and has some built-in checks for > size and alignment. > > Use sysfs_emit() to format the custom `in_power_shunt_resistor` and > `in_current_shunt_resistor` device attributes of the max9611 driver. > > Signed-off-by: Lars-Peter Clausen <lars@xxxxxxxxxx> Looks good, I just wonder if a dependency on the CONFIG_SYSFS symbol should now be added... Thanks j > --- > drivers/iio/adc/max9611.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/iio/adc/max9611.c b/drivers/iio/adc/max9611.c > index 01a4275e9c46..f982f00303dc 100644 > --- a/drivers/iio/adc/max9611.c > +++ b/drivers/iio/adc/max9611.c > @@ -429,7 +429,7 @@ static ssize_t max9611_shunt_resistor_show(struct device *dev, > i = max9611->shunt_resistor_uohm / 1000000; > r = max9611->shunt_resistor_uohm % 1000000; > > - return sprintf(buf, "%u.%06u\n", i, r); > + return sysfs_emit(buf, "%u.%06u\n", i, r); > } > > static IIO_DEVICE_ATTR(in_power_shunt_resistor, 0444, > -- > 2.30.2 >
