Re: [PATCH 1/5 v3] iio: st_sensors: Create extended attr macro

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, May 24, 2021 at 01:37:52PM +0300, Andy Shevchenko wrote:
> On Mon, May 24, 2021 at 10:50:42AM +0100, Jonathan Cameron wrote:
> > On Mon, 24 May 2021 11:43:11 +0200
> > Linus Walleij <linus.walleij@xxxxxxxxxx> wrote:
> > 
> > > On Sat, May 22, 2021 at 8:14 PM Jonathan Cameron <jic23@xxxxxxxxxx> wrote:
> > > 
> > > > @Linus, for IIO stuff, please put a cover letter on series as it makes it
> > > > easier for people to reply with things like this  
> > > 
> > > OK sorry about that, I'll try to keep it in mind.
> > > 
> > > > and still let me use b4
> > > > without manual tweaking.  
> > > 
> > > b4 only need the patches to be sent in a thread which I
> > > actually did, at least this works fine for me from here:
> > > 
> > > tmp]$ b4 am -t 20210518230722.522446-1-linus.walleij@xxxxxxxxxx
> > > Looking up https://lore.kernel.org/r/20210518230722.522446-1-linus.walleij%40linaro.org
> > > Grabbing thread from lore.kernel.org/linux-iio
> > > Analyzing 7 messages in the thread
> > > ---
> > > Writing ./v3_20210519_linus_walleij_iio_st_sensors_create_extended_attr_macro.mbx
> > >   ✓ [PATCH 1/5 v3] iio: st_sensors: Create extended attr macro
> > >     + Reviewed-by: Hans de Goede <hdegoede@xxxxxxxxxx> (✓ DKIM/redhat.com)
> > >   ✓ [PATCH 2/5 v3] iio: accel: st_sensors: Support generic mounting matrix
> > >   ✓ [PATCH 3/5 v3] iio: accel: st_sensors: Stop copying channels
> > >   ✓ [PATCH 4/5 v3] iio: magnetometer: st_magn: Support mount matrix
> > >   ✓ [PATCH 5/5 v3] iio: gyro: st_gyro: Support mount matrix
> > 
> > That only adds the Reviewed-by for patch 1 which was not Hans'
> > intention.  If the reply was to a cover letter it would apply to all of the patches.
> 
> It's easy to fix with `git filter-branch --msg-filter ...`.

But OTOH, tools may not recognize a human intention well from the natural
language, it's also recommended to the reviewers to be explicit that bots can
handle it (here: add a tag per each patch that is considered to be tagged).

-- 
With Best Regards,
Andy Shevchenko





[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Input]     [Linux Kernel]     [Linux SCSI]     [X.org]

  Powered by Linux