On Wed, 12 May 2021 16:22:12 +0200 Mauro Carvalho Chehab <mchehab+huawei@xxxxxxxxxx> wrote: > Em Sun, 9 May 2021 12:33:43 +0100 > Jonathan Cameron <jic23@xxxxxxxxxx> escreveu: > > > From: Jonathan Cameron <Jonathan.Cameron@xxxxxxxxxx> > > > > Found using coccicheck script under review at: > > https://lore.kernel.org/lkml/20210427141946.2478411-1-Julia.Lawall@xxxxxxxx/ > > > > This is a prequel to taking a closer look at the runtime pm in IIO drivers > > in general. > > > > Signed-off-by: Jonathan Cameron <Jonathan.Cameron@xxxxxxxxxx> > > This driver has an extra (unbalanced?) call to pm_runtime_put_noidle() at > ads1015_remove(). Good point. Dropped that as well for v2. > > > --- > > drivers/iio/adc/ti-ads1015.c | 4 +--- > > 1 file changed, 1 insertion(+), 3 deletions(-) > > > > diff --git a/drivers/iio/adc/ti-ads1015.c b/drivers/iio/adc/ti-ads1015.c > > index 9fef39bcf997..4b61ee3d2501 100644 > > --- a/drivers/iio/adc/ti-ads1015.c > > +++ b/drivers/iio/adc/ti-ads1015.c > > @@ -323,9 +323,7 @@ static int ads1015_set_power_state(struct ads1015_data *data, bool on) > > struct device *dev = regmap_get_device(data->regmap); > > > > if (on) { > > - ret = pm_runtime_get_sync(dev); > > - if (ret < 0) > > - pm_runtime_put_noidle(dev); > > + ret = pm_runtime_resume_and_get(dev); > > } else { > > pm_runtime_mark_last_busy(dev); > > ret = pm_runtime_put_autosuspend(dev); > > > > Thanks, > Mauro
