> On 10/05/2021 08.28, Lorenzo Bianconi wrote: > >> On 07/05/2021 13.02, Lorenzo Bianconi wrote: > >>>> The correct way to set the sampling rate to 12.5 Hz before > >>>> commit f8710f0357bc ("iio: imu: st_lsm6dsx: express odr in mHZ") > >>>> was to write 13 Hz to sampling_frequency. > >>>> Before this patch writing 13 to samplerate results in sample rate set > >>>> to 26 Hz. > >>>> Now we return EINVAL if the sampling rate is not in table. > >>>> > >>>> Signed-off-by: Sean Nyekjaer <sean@xxxxxxxxxx> > >>> > >>> I think this patch is breaking i2c-master support available in st_lsm6dsx, have you tested it? > >>> > >> I have not tested with i2c-master. > >> But it's not nice to round up sample rate from user space without any notice. > > > > the point is accel odr is used as trigger for i2c-slave sampling. Connected > > i2c slave devices have different sample rates (e.g. LIS2MDL), so we need to > > select the lower accel odr greather than slave device one. > > > > Regards, > > Lorenzo > > > > We could open up for custom sample rates if i2c-slaves are enabled? can you please explain what you mean? > /Sean
Attachment:
signature.asc
Description: PGP signature