> From: Jonathan Cameron <jic23@xxxxxxxxxx>
> Sent: Saturday, April 24, 2021 1:07 PM
> To: Alexandru Ardelean <ardeleanalex@xxxxxxxxx>
> Cc: Sa, Nuno <Nuno.Sa@xxxxxxxxxx>; linux-iio <linux-
> iio@xxxxxxxxxxxxxxx>; Hennerich, Michael
> <Michael.Hennerich@xxxxxxxxxx>; Lars-Peter Clausen
> <lars@xxxxxxxxxx>
> Subject: Re: [PATCH v2 3/9] iio: adis16475: do not return ints in irq
> handlers
>
> [External]
>
> On Fri, 23 Apr 2021 09:41:26 +0300
> Alexandru Ardelean <ardeleanalex@xxxxxxxxx> wrote:
>
> > On Thu, Apr 22, 2021 at 1:17 PM Nuno Sa <nuno.sa@xxxxxxxxxx>
> wrote:
> > >
> > > On an IRQ handler we should return normal error codes as
> 'irqreturn_t'
> > > is expected.
> > >
> >
> > Reviewed-by: Alexandru Ardelean <ardeleanalex@xxxxxxxxx>
> >
> > > Fixes: fff7352bf7a3c ("iio: imu: Add support for adis16475")
> > > Signed-off-by: Nuno Sa <nuno.sa@xxxxxxxxxx>
>
> Hi Nuno,
>
> This needs a more detailed commit message as it is simply changing
> the return code. That goto does other stuff.
> Please add some more info and send a v3 with this + other patches
> I that build on it and hence I won't be able to apply.
>
> Whilst this one is a real bug, I'm not that fussed about backporting
> it quickly so will probably be fine to take this via togreg once the
> commit message gives enough detail.
Agreed...
- Nuno Sá
