On Fri, 23 Apr 2021 09:41:26 +0300
Alexandru Ardelean <ardeleanalex@xxxxxxxxx> wrote:
> On Thu, Apr 22, 2021 at 1:17 PM Nuno Sa <nuno.sa@xxxxxxxxxx> wrote:
> >
> > On an IRQ handler we should return normal error codes as 'irqreturn_t'
> > is expected.
> >
>
> Reviewed-by: Alexandru Ardelean <ardeleanalex@xxxxxxxxx>
>
> > Fixes: fff7352bf7a3c ("iio: imu: Add support for adis16475")
> > Signed-off-by: Nuno Sa <nuno.sa@xxxxxxxxxx>
Hi Nuno,
This needs a more detailed commit message as it is simply changing
the return code. That goto does other stuff.
Please add some more info and send a v3 with this + other patches
I that build on it and hence I won't be able to apply.
Whilst this one is a real bug, I'm not that fussed about backporting
it quickly so will probably be fine to take this via togreg once the
commit message gives enough detail.
Thanks,
Jonathan
> > ---
> > drivers/iio/imu/adis16475.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/iio/imu/adis16475.c b/drivers/iio/imu/adis16475.c
> > index 1de62fc79e0f..51b76444db0b 100644
> > --- a/drivers/iio/imu/adis16475.c
> > +++ b/drivers/iio/imu/adis16475.c
> > @@ -1068,7 +1068,7 @@ static irqreturn_t adis16475_trigger_handler(int irq, void *p)
> >
> > ret = spi_sync(adis->spi, &adis->msg);
> > if (ret)
> > - return ret;
> > + goto check_burst32;
> >
> > adis->spi->max_speed_hz = cached_spi_speed_hz;
> > buffer = adis->buffer;
> > --
> > 2.31.1
> >
