On Thu, 22 Apr 2021 12:19:04 +0200
Nuno Sa <nuno.sa@xxxxxxxxxx> wrote:
> On an IRQ handler we should not return normal error codes as 'irqreturn_t'
> is expected.
>
> Fixes: 5eda3550a3cc1 ("staging:iio:adis16400: Preallocate transfer message")
> Reviewed-by: Alexandru Ardelean <ardeleanalex@xxxxxxxxx>
> Signed-off-by: Nuno Sa <nuno.sa@xxxxxxxxxx>
Same approach as for previous patch.
Applied to the togreg branch of iio.git and pushed out as testing.
Thanks,
Jonathan
> ---
> drivers/iio/imu/adis16400.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/drivers/iio/imu/adis16400.c b/drivers/iio/imu/adis16400.c
> index 768aa493a1a6..b2f92b55b910 100644
> --- a/drivers/iio/imu/adis16400.c
> +++ b/drivers/iio/imu/adis16400.c
> @@ -645,9 +645,6 @@ static irqreturn_t adis16400_trigger_handler(int irq, void *p)
> void *buffer;
> int ret;
>
> - if (!adis->buffer)
> - return -ENOMEM;
> -
> if (!(st->variant->flags & ADIS16400_NO_BURST) &&
> st->adis.spi->max_speed_hz > ADIS16400_SPI_BURST) {
> st->adis.spi->max_speed_hz = ADIS16400_SPI_BURST;
