-----Original Message----- From: Randy Dunlap [mailto:rdunlap@xxxxxxxxxxxxx] Sent: 26 April 2021 06:44 To: kernel test robot <lkp@xxxxxxxxx>; Jonathan Cameron <jonathan.cameron@xxxxxxxxxx>; linux-clk@xxxxxxxxxxxxxxx Cc: kbuild-all@xxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; Andy Shevchenko <andy.shevchenko@xxxxxxxxx>; Stephen Boyd <sboyd@xxxxxxxxxx>; Michael Turquette <mturquette@xxxxxxxxxxxx> Subject: Re: ingenic-adc.c:undefined reference to `clk_get_parent' [add linux-clk + maintainers] On 3/16/21 8:54 AM, kernel test robot wrote: > tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master > head: 1a4431a5db2bf800c647ee0ed87f2727b8d6c29c > commit: a07a4fe5ff460e99293c0d682421920d54e31d7f iio:adc:ingenic: drop of_match_ptr protection and include mod_devicetable.h > date: 8 months ago > config: mips-randconfig-p001-20210316 (attached as .config) > compiler: mips-linux-gcc (GCC) 9.3.0 > reproduce (this is a W=1 build): > wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross > chmod +x ~/bin/make.cross > # https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=a07a4fe5ff460e99293c0d682421920d54e31d7f > git remote add linus https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git > git fetch --no-tags linus master > git checkout a07a4fe5ff460e99293c0d682421920d54e31d7f > # save the attached .config to linux build tree > COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross > ARCH=mips > > If you fix the issue, kindly add following tag as appropriate > Reported-by: kernel test robot <lkp@xxxxxxxxx> > > All errors (new ones prefixed by >>): > > mips-linux-ld: drivers/iio/adc/ingenic-adc.o: in function `jz4770_adc_init_clk_div': >>> ingenic-adc.c:(.text+0x8c): undefined reference to `clk_get_parent' > mips-linux-ld: drivers/iio/adc/ingenic-adc.o: in function `jz4725b_adc_init_clk_div': > ingenic-adc.c:(.text+0x164): undefined reference to `clk_get_parent' Hi, My guess (analysis) suggests that this problem is due to a difference in when clk_get_parent() is available between <linux/clk.h> where it depends on CONFIG_HAVE_CLK and drivers/clk/clk.c, which is built iff CONFIG_COMMON_CLK. Any comments/suggestions? thanks. -- ~Randy