> -----Original Message----- > From: Jonathan Cameron [mailto:jic23@xxxxxxxxxx] > Sent: Saturday, April 3, 2021 7:46 AM > To: linux-iio@xxxxxxxxxxxxxxx > Cc: Song Bao Hua (Barry Song) <song.bao.hua@xxxxxxxxxxxxx>; Jonathan Cameron > <jonathan.cameron@xxxxxxxxxx>; Alexandre Belloni > <alexandre.belloni@xxxxxxxxxxx> > Subject: [PATCH 3/7] iio:adc:nau7802: Use IRQF_NO_AUTOEN instead of request > then disable > > From: Jonathan Cameron <Jonathan.Cameron@xxxxxxxxxx> > > Whilst a race during interrupt enabling is probably not a problem, > it is better to not enable the interrupt at all. The new > IRQF_NO_AUTOEN flag allows us to do that. > > Signed-off-by: Jonathan Cameron <Jonathan.Cameron@xxxxxxxxxx> > Cc: Alexandre Belloni <alexandre.belloni@xxxxxxxxxxx> > --- Reviewed-by: Barry Song <song.bao.hua@xxxxxxxxxxxxx> > drivers/iio/adc/nau7802.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/iio/adc/nau7802.c b/drivers/iio/adc/nau7802.c > index 07c85434b568..bb70b51d25b1 100644 > --- a/drivers/iio/adc/nau7802.c > +++ b/drivers/iio/adc/nau7802.c > @@ -498,7 +498,8 @@ static int nau7802_probe(struct i2c_client *client, > ret = request_threaded_irq(client->irq, > NULL, > nau7802_eoc_trigger, > - IRQF_TRIGGER_HIGH | IRQF_ONESHOT, > + IRQF_TRIGGER_HIGH | IRQF_ONESHOT | > + IRQF_NO_AUTOEN, > client->dev.driver->name, > indio_dev); > if (ret) { > @@ -513,8 +514,7 @@ static int nau7802_probe(struct i2c_client *client, > dev_info(&client->dev, > "Failed to allocate IRQ, using polling mode\n"); > client->irq = 0; > - } else > - disable_irq(client->irq); > + } > } > > if (!client->irq) { > -- > 2.31.1
