> -----Original Message----- > From: Jonathan Cameron [mailto:jic23@xxxxxxxxxx] > Sent: Saturday, April 3, 2021 7:46 AM > To: linux-iio@xxxxxxxxxxxxxxx > Cc: Song Bao Hua (Barry Song) <song.bao.hua@xxxxxxxxxxxxx>; Jonathan Cameron > <jonathan.cameron@xxxxxxxxxx>; Krzysztof Kozlowski <krzk@xxxxxxxxxx> > Subject: [PATCH 2/7] iio:adc:exynos-adc: Use new IRQF_NO_AUTOEN flag rather > than separate irq_disable() > > From: Jonathan Cameron <Jonathan.Cameron@xxxxxxxxxx> > > Disabling an irq before the driver has actually atempted to request it > may work, but is definitely not as clean as just requesting it as > normal but with the auto enable disabled. > > Signed-off-by: Jonathan Cameron <Jonathan.Cameron@xxxxxxxxxx> > Cc: Krzysztof Kozlowski <krzk@xxxxxxxxxx> > --- > drivers/iio/adc/exynos_adc.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > Reviewed-by: Barry Song <song.bao.hua@xxxxxxxxxxxxx> > diff --git a/drivers/iio/adc/exynos_adc.c b/drivers/iio/adc/exynos_adc.c > index 784c10deeb1a..8c98d8c9ab1f 100644 > --- a/drivers/iio/adc/exynos_adc.c > +++ b/drivers/iio/adc/exynos_adc.c > @@ -778,9 +778,9 @@ static int exynos_adc_ts_init(struct exynos_adc *info) > return ret; > } > > - disable_irq(info->tsirq); > ret = request_threaded_irq(info->tsirq, NULL, exynos_ts_isr, > - IRQF_ONESHOT, "touchscreen", info); > + IRQF_ONESHOT | IRQF_NO_AUTOEN, > + "touchscreen", info); > if (ret) > input_unregister_device(info->input); > > -- > 2.31.1
