Re: [PATCH] iio:cros_ec_sensors: Fix a wrong function name in kernel doc.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Jonathan,

Thank you for fix this.

On 13/3/21 15:53, Jonathan Cameron wrote:
> From: Jonathan Cameron <Jonathan.Cameron@xxxxxxxxxx>
> 
> cros_ec_sensors_read_data_unsafe() had wrong function name in kernel-doc
> This shows up with W=1 builds.
> 
> No fixes tag because I don't want to waste time on this being
> backported.
> 
> Signed-off-by: Jonathan Cameron <Jonathan.Cameron@xxxxxxxxxx>
> Cc: Guenter Roeck <groeck@xxxxxxxxxxxx>
> Cc: Douglas Anderson <dianders@xxxxxxxxxxxx>
> Cc: Gwendal Grignou <gwendal@xxxxxxxxxxxx>
> Cc: Enric Balletbo i Serra <enric.balletbo@xxxxxxxxxxxxx>
> ---
>  drivers/iio/common/cros_ec_sensors/cros_ec_sensors_core.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/iio/common/cros_ec_sensors/cros_ec_sensors_core.c b/drivers/iio/common/cros_ec_sensors/cros_ec_sensors_core.c
> index f8824afe595e..ed9dd0ad5c03 100644
> --- a/drivers/iio/common/cros_ec_sensors/cros_ec_sensors_core.c
> +++ b/drivers/iio/common/cros_ec_sensors/cros_ec_sensors_core.c
> @@ -559,7 +559,7 @@ static int cros_ec_sensors_read_until_not_busy(
>  }
>  
>  /**
> - * read_ec_sensors_data_unsafe() - read acceleration data from EC shared memory
> + * cros_ec_sensors_read_data_unsafe() - read acc data from EC shared memory


nit: Wouldn't be better to maintain the word 'acceleration' instead of replacing
for 'acc'. It is less than 100 characters in total so should be fine.

In any case:

Acked-by: Enric Balletbo i Serra <enric.balletbo@xxxxxxxxxxxxx>

>   * @indio_dev:	pointer to IIO device
>   * @scan_mask:	bitmap of the sensor indices to scan
>   * @data:	location to store data
> 



[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Input]     [Linux Kernel]     [Linux SCSI]     [X.org]

  Powered by Linux