RE: [PATCH 05/24] staging:iio:cdc:ad7150: Drop platform data support

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




> -----Original Message-----
> From: Jonathan Cameron [mailto:jic23@xxxxxxxxxx]
> Sent: Monday, February 8, 2021 4:46 AM
> To: linux-iio@xxxxxxxxxxxxxxx
> Cc: Lars-Peter Clausen <lars@xxxxxxxxxx>; Michael Hennerich
> <Michael.Hennerich@xxxxxxxxxx>; Song Bao Hua (Barry Song)
> <song.bao.hua@xxxxxxxxxxxxx>; robh+dt@xxxxxxxxxx; Jonathan Cameron
> <jonathan.cameron@xxxxxxxxxx>
> Subject: [PATCH 05/24] staging:iio:cdc:ad7150: Drop platform data support
> 
> From: Jonathan Cameron <Jonathan.Cameron@xxxxxxxxxx>
> 
> There are no mainline board files using this driver so lets drop
> the platform_data support in favour of devicetree and similar.
> 
> Signed-off-by: Jonathan Cameron <Jonathan.Cameron@xxxxxxxxxx>
> ---
>  drivers/staging/iio/cdc/ad7150.c | 14 --------------
>  1 file changed, 14 deletions(-)
> 
> diff --git a/drivers/staging/iio/cdc/ad7150.c
> b/drivers/staging/iio/cdc/ad7150.c
> index 0dce1b8ce76d..7ad9105e6b46 100644
> --- a/drivers/staging/iio/cdc/ad7150.c
> +++ b/drivers/staging/iio/cdc/ad7150.c
> @@ -570,20 +570,6 @@ static int ad7150_probe(struct i2c_client *client,
>  			return ret;
>  	}
> 
> -	if (client->dev.platform_data) {
> -		ret = devm_request_threaded_irq(&client->dev, *(unsigned int *)
> -						client->dev.platform_data,
> -						NULL,
> -						&ad7150_event_handler,
> -						IRQF_TRIGGER_RISING |
> -						IRQF_TRIGGER_FALLING |
> -						IRQF_ONESHOT,
> -						"ad7150_irq2",
> -						indio_dev);
> -		if (ret)
> -			return ret;
> -	}
> -

The original code looks ugly, I forget when ad7150 needs
the second interrupt.

>  	ret = devm_iio_device_register(indio_dev->dev.parent, indio_dev);
>  	if (ret)
>  		return ret;
> --
> 2.30.0

Thanks
Barry




[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Input]     [Linux Kernel]     [Linux SCSI]     [X.org]

  Powered by Linux