Coccinele could not catch these, because the 'modes' assignment is done in a common-probe code for all these drivers. These drivers support 2 probing modes, and the common probe code is the one that initializes the 'modes'. These change removes the 'modes' init for these drivers, since they only initialize to INDIO_DIRECT_MODE only. Signed-off-by: Alexandru Ardelean <alexandru.ardelean@xxxxxxxxxx> --- drivers/iio/accel/st_accel_core.c | 1 - drivers/iio/adc/ltc2497-core.c | 1 - drivers/iio/gyro/st_gyro_core.c | 1 - drivers/iio/magnetometer/st_magn_core.c | 1 - drivers/iio/pressure/ms5611_core.c | 1 - drivers/iio/pressure/st_pressure_core.c | 1 - drivers/iio/temperature/tsys01.c | 1 - drivers/staging/iio/meter/ade7854.c | 1 - 8 files changed, 8 deletions(-) diff --git a/drivers/iio/accel/st_accel_core.c b/drivers/iio/accel/st_accel_core.c index 43c50167d220..18d91328a3ec 100644 --- a/drivers/iio/accel/st_accel_core.c +++ b/drivers/iio/accel/st_accel_core.c @@ -1252,7 +1252,6 @@ int st_accel_common_probe(struct iio_dev *indio_dev) size_t channels_size; int err; - indio_dev->modes = INDIO_DIRECT_MODE; indio_dev->info = &accel_info; err = st_sensors_power_enable(indio_dev); diff --git a/drivers/iio/adc/ltc2497-core.c b/drivers/iio/adc/ltc2497-core.c index 2a485c8a1940..34e64252837a 100644 --- a/drivers/iio/adc/ltc2497-core.c +++ b/drivers/iio/adc/ltc2497-core.c @@ -171,7 +171,6 @@ int ltc2497core_probe(struct device *dev, struct iio_dev *indio_dev) indio_dev->name = dev_name(dev); indio_dev->info = <c2497core_info; - indio_dev->modes = INDIO_DIRECT_MODE; indio_dev->channels = ltc2497core_channel; indio_dev->num_channels = ARRAY_SIZE(ltc2497core_channel); diff --git a/drivers/iio/gyro/st_gyro_core.c b/drivers/iio/gyro/st_gyro_core.c index c8aa051995d3..a48e43544d46 100644 --- a/drivers/iio/gyro/st_gyro_core.c +++ b/drivers/iio/gyro/st_gyro_core.c @@ -463,7 +463,6 @@ int st_gyro_common_probe(struct iio_dev *indio_dev) struct st_sensors_platform_data *pdata; int err; - indio_dev->modes = INDIO_DIRECT_MODE; indio_dev->info = &gyro_info; err = st_sensors_power_enable(indio_dev); diff --git a/drivers/iio/magnetometer/st_magn_core.c b/drivers/iio/magnetometer/st_magn_core.c index 79de721e6015..95606de1535e 100644 --- a/drivers/iio/magnetometer/st_magn_core.c +++ b/drivers/iio/magnetometer/st_magn_core.c @@ -491,7 +491,6 @@ int st_magn_common_probe(struct iio_dev *indio_dev) struct st_sensor_data *mdata = iio_priv(indio_dev); int err; - indio_dev->modes = INDIO_DIRECT_MODE; indio_dev->info = &magn_info; err = st_sensors_power_enable(indio_dev); diff --git a/drivers/iio/pressure/ms5611_core.c b/drivers/iio/pressure/ms5611_core.c index 214b0d25f598..7c8094f5ae93 100644 --- a/drivers/iio/pressure/ms5611_core.c +++ b/drivers/iio/pressure/ms5611_core.c @@ -444,7 +444,6 @@ int ms5611_probe(struct iio_dev *indio_dev, struct device *dev, indio_dev->info = &ms5611_info; indio_dev->channels = ms5611_channels; indio_dev->num_channels = ARRAY_SIZE(ms5611_channels); - indio_dev->modes = INDIO_DIRECT_MODE; indio_dev->available_scan_masks = ms5611_scan_masks; ret = ms5611_init(indio_dev); diff --git a/drivers/iio/pressure/st_pressure_core.c b/drivers/iio/pressure/st_pressure_core.c index 789a2928504a..695f77dd4f9f 100644 --- a/drivers/iio/pressure/st_pressure_core.c +++ b/drivers/iio/pressure/st_pressure_core.c @@ -686,7 +686,6 @@ int st_press_common_probe(struct iio_dev *indio_dev) struct st_sensors_platform_data *pdata = dev_get_platdata(press_data->dev); int err; - indio_dev->modes = INDIO_DIRECT_MODE; indio_dev->info = &press_info; err = st_sensors_power_enable(indio_dev); diff --git a/drivers/iio/temperature/tsys01.c b/drivers/iio/temperature/tsys01.c index bbfbad9a8767..6d42dfea050a 100644 --- a/drivers/iio/temperature/tsys01.c +++ b/drivers/iio/temperature/tsys01.c @@ -161,7 +161,6 @@ static int tsys01_probe(struct iio_dev *indio_dev, struct device *dev) indio_dev->info = &tsys01_info; indio_dev->name = dev->driver->name; - indio_dev->modes = INDIO_DIRECT_MODE; indio_dev->channels = tsys01_channels; indio_dev->num_channels = ARRAY_SIZE(tsys01_channels); diff --git a/drivers/staging/iio/meter/ade7854.c b/drivers/staging/iio/meter/ade7854.c index 68da6ecde6a3..e350761dd3f5 100644 --- a/drivers/staging/iio/meter/ade7854.c +++ b/drivers/staging/iio/meter/ade7854.c @@ -540,7 +540,6 @@ int ade7854_probe(struct iio_dev *indio_dev, struct device *dev) indio_dev->dev.parent = dev; indio_dev->info = &ade7854_info; - indio_dev->modes = INDIO_DIRECT_MODE; ret = devm_iio_device_register(dev, indio_dev); if (ret) -- 2.27.0