On Sat, Oct 31, 2020 at 12:10 PM Jonathan Cameron <jic23@xxxxxxxxxx> wrote: > [snip] > > > > Hi Jonathan, > > > > My two priorities for the ordering of this series were: correct > > end-result and not breaking anything on the way. The latter > > unfortunately gets in the way of cleaner looking intermediate patches. > > > > I tried to not alter the ordering in which the resources are freed at > > any step. As devres release callbacks are called *after* remove() and > > in a reverse order to how they were registered, I needed to start from > > the bottom of the remove() callback and convert the last operation, > > then go upwards from there. > > > > If I tried to do it from the top - I probably could remove labels > > earlier and in a cleaner manner but it wouldn't guarantee > > bisectability. > > > > Maybe best plan is to squash last 3 patches into one? > > I suspect that's going to be easier to review. > > Jonathan > Sure I can do this. Bartosz
