Works for me on the Galaxy S.
Tested-by: Jonathan Bakker <xc-racer2@xxxxxxx>
Thanks,
Jonathan
On 2020-09-07 9:11 a.m., Krzysztof Kozlowski wrote:
> The fixed clocks are kept under dedicated 'external-clocks' node, thus a
> fake 'reg' was added. This is not correct with dtschema as fixed-clock
> binding does not have a 'reg' property. Moving fixed clocks out of
> 'soc' to root node fixes multiple dtbs_check warnings:
>
> external-clocks: $nodename:0: 'external-clocks' does not match '^([a-z][a-z0-9\\-]+-bus|bus|soc|axi|ahb|apb)(@[0-9a-f]+)?$'
> external-clocks: #size-cells:0:0: 0 is not one of [1, 2]
> external-clocks: oscillator@0:reg:0: [0] is too short
> external-clocks: oscillator@1:reg:0: [1] is too short
> external-clocks: 'ranges' is a required property
> oscillator@0: 'reg' does not match any of the regexes: 'pinctrl-[0-9]+'
>
> Signed-off-by: Krzysztof Kozlowski <krzk@xxxxxxxxxx>
> ---
> arch/arm/boot/dts/s5pv210.dtsi | 36 +++++++++++++---------------------
> 1 file changed, 14 insertions(+), 22 deletions(-)
>
> diff --git a/arch/arm/boot/dts/s5pv210.dtsi b/arch/arm/boot/dts/s5pv210.dtsi
> index 84e4447931de..5c760a6d7955 100644
> --- a/arch/arm/boot/dts/s5pv210.dtsi
> +++ b/arch/arm/boot/dts/s5pv210.dtsi
> @@ -52,34 +52,26 @@
> };
> };
>
> + xxti: oscillator-0 {
> + compatible = "fixed-clock";
> + clock-frequency = <0>;
> + clock-output-names = "xxti";
> + #clock-cells = <0>;
> + };
> +
> + xusbxti: oscillator-1 {
> + compatible = "fixed-clock";
> + clock-frequency = <0>;
> + clock-output-names = "xusbxti";
> + #clock-cells = <0>;
> + };
> +
> soc {
> compatible = "simple-bus";
> #address-cells = <1>;
> #size-cells = <1>;
> ranges;
>
> - external-clocks {
> - compatible = "simple-bus";
> - #address-cells = <1>;
> - #size-cells = <0>;
> -
> - xxti: oscillator@0 {
> - compatible = "fixed-clock";
> - reg = <0>;
> - clock-frequency = <0>;
> - clock-output-names = "xxti";
> - #clock-cells = <0>;
> - };
> -
> - xusbxti: oscillator@1 {
> - compatible = "fixed-clock";
> - reg = <1>;
> - clock-frequency = <0>;
> - clock-output-names = "xusbxti";
> - #clock-cells = <0>;
> - };
> - };
> -
> onenand: onenand@b0600000 {
> compatible = "samsung,s5pv210-onenand";
> reg = <0xb0600000 0x2000>,
>
