DMA still works for me on the Galaxy S.
Tested-by: Jonathan Bakker <xc-racer2@xxxxxxx>
Thanks,
Jonathan
On 2020-09-07 9:11 a.m., Krzysztof Kozlowski wrote:
> There is no need to keep DMA controller nodes under AMBA bus node.
> Remove the "amba" node to fix dtschema warnings like:
>
> amba: $nodename:0: 'amba' does not match '^([a-z][a-z0-9\\-]+-bus|bus|soc|axi|ahb|apb)(@[0-9a-f]+)?$'
>
> Signed-off-by: Krzysztof Kozlowski <krzk@xxxxxxxxxx>
> ---
> arch/arm/boot/dts/s5pv210.dtsi | 49 +++++++++++++++-------------------
> 1 file changed, 21 insertions(+), 28 deletions(-)
>
> diff --git a/arch/arm/boot/dts/s5pv210.dtsi b/arch/arm/boot/dts/s5pv210.dtsi
> index 1b0ee884e91d..84e4447931de 100644
> --- a/arch/arm/boot/dts/s5pv210.dtsi
> +++ b/arch/arm/boot/dts/s5pv210.dtsi
> @@ -128,35 +128,28 @@
> };
> };
>
> - amba {
> - #address-cells = <1>;
> - #size-cells = <1>;
> - compatible = "simple-bus";
> - ranges;
> -
> - pdma0: dma@e0900000 {
> - compatible = "arm,pl330", "arm,primecell";
> - reg = <0xe0900000 0x1000>;
> - interrupt-parent = <&vic0>;
> - interrupts = <19>;
> - clocks = <&clocks CLK_PDMA0>;
> - clock-names = "apb_pclk";
> - #dma-cells = <1>;
> - #dma-channels = <8>;
> - #dma-requests = <32>;
> - };
> + pdma0: dma@e0900000 {
> + compatible = "arm,pl330", "arm,primecell";
> + reg = <0xe0900000 0x1000>;
> + interrupt-parent = <&vic0>;
> + interrupts = <19>;
> + clocks = <&clocks CLK_PDMA0>;
> + clock-names = "apb_pclk";
> + #dma-cells = <1>;
> + #dma-channels = <8>;
> + #dma-requests = <32>;
> + };
>
> - pdma1: dma@e0a00000 {
> - compatible = "arm,pl330", "arm,primecell";
> - reg = <0xe0a00000 0x1000>;
> - interrupt-parent = <&vic0>;
> - interrupts = <20>;
> - clocks = <&clocks CLK_PDMA1>;
> - clock-names = "apb_pclk";
> - #dma-cells = <1>;
> - #dma-channels = <8>;
> - #dma-requests = <32>;
> - };
> + pdma1: dma@e0a00000 {
> + compatible = "arm,pl330", "arm,primecell";
> + reg = <0xe0a00000 0x1000>;
> + interrupt-parent = <&vic0>;
> + interrupts = <20>;
> + clocks = <&clocks CLK_PDMA1>;
> + clock-names = "apb_pclk";
> + #dma-cells = <1>;
> + #dma-channels = <8>;
> + #dma-requests = <32>;
> };
>
> adc: adc@e1700000 {
>
