Re: [RFC PATCH 2/2] iio: st-accel: Add support for Silan SC7A20 and SC7A30E

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sun, 16 Aug 2020 18:27:03 +0900
Daniel Palmer <daniel@xxxxxxxx> wrote:

> Hi Jonathan,
> 
> On Sun, 16 Aug 2020 at 17:52, Jonathan Cameron <jic23@xxxxxxxxxx> wrote:
> > Same issue with sign off.  
> 
> I didn't think that was needed for an RFC. I'll add the sign off to the v1.

I'd always put them in anyway as RFCs sometimes get picked up if the
comments are all positive!

> 
> > + Needs to be added to the device tree documentation in
> > Documentation/devicetree/bindings/iio/st-sensors.txt  
> 
> I'll add that in. Other than that was the change OK? I wasn't sure a
> massive copy/paste
> would be acceptable.

It's always a trade off with cases like this on whether we want to
add complexity to the code to handle different WAI values, or just
have a bit more constant data and replicate stuff.

I'm fine with the replicating options, but of course others may not be.

Jonathan

> 
> Thanks,
> 
> Daniel




[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Input]     [Linux Kernel]     [Linux SCSI]     [X.org]

  Powered by Linux