Re: [PATCH v9 1/2] iio: humidity: Add TI HDC20x0 support

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Aug 3, 2020 at 5:44 PM Eugene Zaikonnikov <ez@xxxxxxxxxxxxx> wrote:

> Sorry for the attachments, it was an accident.
I hope the next version will be sent properly.

> > On Fri, Jul 10, 2020 at 2:54 PM Eugene Zaikonnikov <ez@xxxxxxxxxxxxx> wrote:
>
> [...]
>
> > 8. It's one line
> > ret = i2c_smbus_write_byte_data(client,
> >     HDC2010_REG_MEASUREMENT_CONF, tmp);
> >
> > Ditto:
> > dev_warn(&client->dev, "Unable to restore default AMM\n");
> >
> Must be misunderstanding something, as neither of these fits 80 column
> fill if made into one line. Found also couple other places I need in
> fact to wrap down to 80.

For how many? And since it's a new driver you may use 100.
Besides that there is no limitation for the messages for a long time
(see dev_warn() example above).

-- 
With Best Regards,
Andy Shevchenko



[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Input]     [Linux Kernel]     [Linux SCSI]     [X.org]

  Powered by Linux