Apologies from my side for being too much of a patch-bot here.
I should have also given some more thought to the patch.
Atm, I'm sending this from Outlook, since [for some reason] the Linux mail-client isn't working.
[ Which is why this isn't properly inlined either ]
I'll send a V2.
-----Original Message-----
From: Lars-Peter Clausen <lars@xxxxxxxxxx>
Sent: Saturday, July 18, 2020 7:37 PM
To: Jonathan Cameron <jic23@xxxxxxxxxx>; Ardelean, Alexandru <alexandru.Ardelean@xxxxxxxxxx>
Cc: linux-iio@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx
Subject: Re: [PATCH] iio: trigger: Staticise stub functions
[External]
On 7/18/20 6:25 PM, Jonathan Cameron wrote:
> On Tue, 14 Jul 2020 17:24:56 +0300
> Alexandru Ardelean <alexandru.ardelean@xxxxxxxxxx> wrote:
>
>> From: Lars-Peter Clausen <lars@xxxxxxxxxx>
>>
>> Make sure that the trigger function stubs are all static inline.
>> Otherwise we'll get linker errors due to multiple definitions of the same function.
>>
>> Fixes f8c6f4e9a40d4: ("iio: trigger: Staticise stub functions")
>> Signed-off-by: Lars-Peter Clausen <lars@xxxxxxxxxx>
>> Signed-off-by: Alexandru Ardelean <alexandru.ardelean@xxxxxxxxxx>
> I'm curious on what the actual build error is? Static functions
> should result in independent implementations in each C file that
> includes them. Inline is normally considered a hint. Hence what am I missing?
It's a bad commit message, my fault. This should have been
Make sure that the trigger function stubs are all static inline.
Otherwise we might see compiler warnings about declared but unused functions.
