Re: [PATCH] iio: trigger: Staticise stub functions

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 7/18/20 6:25 PM, Jonathan Cameron wrote:
On Tue, 14 Jul 2020 17:24:56 +0300
Alexandru Ardelean <alexandru.ardelean@xxxxxxxxxx> wrote:

From: Lars-Peter Clausen <lars@xxxxxxxxxx>

Make sure that the trigger function stubs are all static inline. Otherwise
we'll get linker errors due to multiple definitions of the same function.

Fixes f8c6f4e9a40d4: ("iio: trigger: Staticise stub functions")
Signed-off-by: Lars-Peter Clausen <lars@xxxxxxxxxx>
Signed-off-by: Alexandru Ardelean <alexandru.ardelean@xxxxxxxxxx>
I'm curious on what the actual build error is?  Static functions should
result in independent implementations in each C file that includes
them. Inline is normally considered a hint.  Hence what am I missing?

It's a bad commit message, my fault. This should have been

Make sure that the trigger function stubs are all static inline. Otherwise we might see compiler warnings about declared but unused functions.





[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Input]     [Linux Kernel]     [Linux SCSI]     [X.org]

  Powered by Linux