Re: [PATCH] iio: adc: ad7192: fix null de-ref crash during probe

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, 2020-04-06 at 21:46 +0200, Markus Elfring wrote:
> > After that patch 'spi_get_device_id(spi)' returns NULL, so this crashes
> > during probe with null de-ref.
> 
> How do you think about to use the term “null pointer dereference”
> in the commit message?

depends how long the commit title with be
will take a look

> 
> 
> > Fixes 66614ab2be38: ("staging: iio: adc: ad7192: removed spi_device_id")
> 
> Please correct this tag.
> https://urldefense.com/v3/__https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?id=7e63420847ae5f1036e4f7c42f0b3282e73efbc2*n183__;Iw!!A3Ni8CS0y2Y!uk9bOaD_449N0PxwtQ_WikWYY5KnpykeZTp-rbrRTju7FZM6fPd48zCD1pe7rTSYypKYkg$ 
> 
> Why was a colon misplaced here?

will fix
thanks

> 
> Regards,
> Markus




[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Input]     [Linux Kernel]     [Linux SCSI]     [X.org]

  Powered by Linux