> After that patch 'spi_get_device_id(spi)' returns NULL, so this crashes > during probe with null de-ref. How do you think about to use the term “null pointer dereference” in the commit message? > Fixes 66614ab2be38: ("staging: iio: adc: ad7192: removed spi_device_id") Please correct this tag. https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?id=7e63420847ae5f1036e4f7c42f0b3282e73efbc2#n183 Why was a colon misplaced here? Regards, Markus