On Mon, Apr 6, 2020 at 2:20 PM Lorenzo Bianconi <lorenzo@xxxxxxxxxx> wrote: > > On Mon, Apr 6, 2020 at 1:52 PM Lorenzo Bianconi <lorenzo@xxxxxxxxxx> wrote: > > > > > > st_sensors.h contains common stm sensor definitions but in > > > > > st_lsm6dsx_shub driver it is used just to introduce the default > > > > Still doesn't fully clear why only this part of the st_lsm6dsx is not > > okay with the header. > > You need to explain that common/st_sensors is for separate ST sensor > > drivers, while LSM6DSx is a driver for certain IMU which *does not* > > use ST common infrastructure. > > I guess it is pretty simple and evident: we did not use it at all before > the LISM3DL commit and at moment we need it just for ST_SENSORS_DEFAULT_WAI_ADDRESS > definition. It is better to hard code the value directly. Yes, my point is that for a reader (*) of this commit message is not fully clear why on a sudden we did that. (*) the reader may not know full history. > > > wai address for LIS3MDL sensor. > > > Drop this largely unconnected include and introduce the default wai > > > address in st_lsm6dsx_ext_dev_settings register map -- With Best Regards, Andy Shevchenko
