Re: [PATCH] iio: imu: st_lsm6dsx: drop huge include in sensor-hub driver

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Apr 6, 2020 at 1:23 PM Lorenzo Bianconi <lorenzo@xxxxxxxxxx> wrote:
>
> Drop largely unconnected driver include to just introduce default wai
> address and use the value directly st_lsm6dsx_ext_dev_settings register
> map

The commit message is confusing.
Though I now see the issue (the mentioned header is not related to
this certain driver, i.e. st_lsm6dsx).

After addressing commit message issue,
Reviewed-by: Andy Shevchenko <andy.shevchenko@xxxxxxxxx>
IIRC it was me, who didn't check this before during review.

> Signed-off-by: Lorenzo Bianconi <lorenzo@xxxxxxxxxx>
> ---
>  drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_shub.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_shub.c b/drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_shub.c
> index 280925dd8edb..947ca3a7dcaf 100644
> --- a/drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_shub.c
> +++ b/drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_shub.c
> @@ -28,7 +28,6 @@
>  #include <linux/iio/sysfs.h>
>  #include <linux/bitfield.h>
>
> -#include <linux/iio/common/st_sensors.h>
>  #include "st_lsm6dsx.h"
>
>  #define ST_LSM6DSX_SLV_ADDR(n, base)           ((base) + (n) * 3)
> @@ -93,7 +92,7 @@ static const struct st_lsm6dsx_ext_dev_settings st_lsm6dsx_ext_dev_table[] = {
>         {
>                 .i2c_addr = { 0x1e },
>                 .wai = {
> -                       .addr = ST_SENSORS_DEFAULT_WAI_ADDRESS,
> +                       .addr = 0x0f,
>                         .val = 0x3d,
>                 },
>                 .id = ST_LSM6DSX_ID_MAGN,
> --
> 2.25.1
>


-- 
With Best Regards,
Andy Shevchenko



[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Input]     [Linux Kernel]     [Linux SCSI]     [X.org]

  Powered by Linux