06.02.2020 14:48, Jonathan Cameron пишет: > On Tue, 4 Feb 2020 10:30:34 +0100 > David Heidelberg <david@xxxxxxx> wrote: > >> Based on: >> - 3320A in-kernel driver >> - https://www.spinics.net/lists/linux-iio/msg25145.html >> - https://lore.kernel.org/patchwork/patch/684179/ >> >> I decided to keep it aside of AL3320A due to different approach and much >> simpler design of 3010. >> >> Tested on Nexus 7 2012 (grouper/tilapia). >> >> Tested-by: David Heidelberg <david@xxxxxxx> >> Tested-by: Dmitry Osipenko <digetx@xxxxxxxxx> >> Tested-by: Michał Mirosław <mirq-linux@xxxxxxxxxxxx> >> Reviewed-by: Dmitry Osipenko <digetx@xxxxxxxxx> >> Signed-off-by: David Heidelberg <david@xxxxxxx> >> >> v4: >> - SQUASHed: iio: light: al3010 implement suspend support >> - switched from _remove to devm_add_action_or_reset >> - implement bitfields FIELD_PREP & FIELD_GET, no functionality change >> >> Signed-off-by: David Heidelberg <david@xxxxxxx> > > This is fine as is, but you might want to think about adding basic > regulator control as VDD might not be turned on. > Then there is the follow up question on whether it is sensible to > disable VDD in the suspend path. Nexus 7 uses always-ON regulator for the AL3010 VDD. It should be better if VDD enable/disable could be implemented by somebody who could actually test it.
