04.02.2020 12:30, David Heidelberg пишет: > Based on: > - 3320A in-kernel driver > - https://www.spinics.net/lists/linux-iio/msg25145.html > - https://lore.kernel.org/patchwork/patch/684179/ > > I decided to keep it aside of AL3320A due to different approach and much > simpler design of 3010. > > Tested on Nexus 7 2012 (grouper/tilapia). > > Tested-by: David Heidelberg <david@xxxxxxx> > Tested-by: Dmitry Osipenko <digetx@xxxxxxxxx> > Tested-by: Michał Mirosław <mirq-linux@xxxxxxxxxxxx> > Reviewed-by: Dmitry Osipenko <digetx@xxxxxxxxx> > Signed-off-by: David Heidelberg <david@xxxxxxx> Yours signed-off-by tag is duplicated. > > v4: > - SQUASHed: iio: light: al3010 implement suspend support > - switched from _remove to devm_add_action_or_reset > - implement bitfields FIELD_PREP & FIELD_GET, no functionality change > > Signed-off-by: David Heidelberg <david@xxxxxxx> > --- ^^^ It's more preferred to put the change log under the ---, that way it won't end up in the commit's message and patch will still apply because everything in between of --- and the diff is ignored by the `git am`. ... > + > +#define AL3010_GAIN_MASK (BIT(6) | BIT(5) | BIT(4)) What about to use GENMASK macro here: #define AL3010_GAIN_MASK GENMASK(6, 4))
