On Mon, Dec 23, 2019 at 6:28 PM Jonathan Cameron <jic23@xxxxxxxxxx> wrote: > On Wed, 11 Dec 2019 22:38:19 +0100 > Linus Walleij <linus.walleij@xxxxxxxxxx> wrote: > > > This adds support for the BMA254 variant of this > > accelerometer. The only difference for the simple IIO > > driver is that values are 12 bit and the temperature > > offset differs by 1 degree. > > > > Cc: Peter Meerwald <pmeerw@xxxxxxxxxx> > > Cc: Oleksandr Kravchenko <o.v.kravchenko@xxxxxxxxxxxxxxx> > > Cc: devicetree@xxxxxxxxxxxxxxx > > Signed-off-by: Linus Walleij <linus.walleij@xxxxxxxxxx> > > I'm never keen on wildcards, and there is a bma253. > > So please go back to using explicit part numbers. > If you feel a need to indicate a particular structure > applies to multiple devices, then use a comment to do so. Actually when writing the patch I had the datasheets for BMA250, BMA253 and BMA255 at hand as well. The cases where I have labeled variables "25x" is where the models are identical, so as to make things easier for people that want to add support for BMA253 and BMA255. What about copy/paste the previous paragraph into the commit message and call it a day? Or do you prefer that I edit that comment into the driver file and resend? Either works with me. Yours, Linus Walleij
