On Mon, 16 Dec 2019 09:37:36 +0100
Uwe Kleine-König <u.kleine-koenig@xxxxxxxxxxxxxx> wrote:
> Hello Jonathan,
>
> On Sun, Dec 15, 2019 at 11:49:58AM +0000, Jonathan Cameron wrote:
> > On Mon, 9 Dec 2019 21:32:46 +0100
> > Uwe Kleine-König <u.kleine-koenig@xxxxxxxxxxxxxx> wrote:
> >
> > > The ADC only requires the standard stuff for spi devices and a reference
> > > voltage.
> > >
> > > Signed-off-by: Uwe Kleine-König <u.kleine-koenig@xxxxxxxxxxxxxx>
> > Thanks for figuring out what was wrong and fixing it up.
>
> It wasn't done primarily to do you a favour :-)
>
> > > + spi-max-frequency:
> > > + description: maximal spi bus frequency supported by the chip
> >
> > dropped the "by the chip" as this is also about the wiring on the board. If it
> > were just the chip, it could be put in the driver. The unknown bit is
> > if there is some other reason why it might need to be set lower than the maximum.
>
> fine for me.
>
> > > +required:
> > > + - compatible
> > > + - vref-supply
> > > + - reg
> > > +
> > > +examples:
> > > + - |
> > > + spi {
> > > + #address-cells = <1>;
> > > + #size-cells = <0>;
> > > +
> > > + adc@0 {
> > > + compatible = "lltc,ltc2496";
> > You can't easily see it here, but this is a mixture of spaces
> > and tabs. Should be all spaces. I've tidied that up.
>
> I did that on purpose, spaces to have the needed indention for the yaml
> syntax and then tabs for dts indention (as done in the dts itself, too).
> I thought this to be the right mix, but this was my first yaml binding,
> so you're probably right.
I'll be honest, I'm far from sure on this.
I usually rely on Rob moaning about it if it's wrong :)
Oh well. What's there builds. If we get a 'fix' later then so be it.
Thanks,
Jonathan
>
> Best regards and thanks
> Uwe
>
