On Wed, 11 Dec 2019 07:26:07 +0000 "Ardelean, Alexandru" <alexandru.Ardelean@xxxxxxxxxx> wrote: > On Tue, 2019-12-10 at 12:08 -0300, Daniel Junho wrote: > > [External] > > > > Removes the unused define AD7923_CHANNEL_x from the code. > > > > Signed-off-by: Daniel Junho <djunho@xxxxxxxxx> > > --- > > drivers/iio/adc/ad7923.c | 4 ---- > > 1 file changed, 4 deletions(-) > > > > diff --git a/drivers/iio/adc/ad7923.c b/drivers/iio/adc/ad7923.c > > index 3212eb4c0f25..969c06b7d2b7 100644 > > --- a/drivers/iio/adc/ad7923.c > > +++ b/drivers/iio/adc/ad7923.c > > @@ -29,10 +29,6 @@ > > #define AD7923_PM_MODE_AS (1) /* auto shutdown */ > > #define AD7923_PM_MODE_FS (2) /* full shutdown */ > > #define AD7923_PM_MODE_OPS (3) /* normal operation */ > > -#define AD7923_CHANNEL_0 (0) /* analog input 0 */ > > -#define AD7923_CHANNEL_1 (1) /* analog input 1 */ > > -#define AD7923_CHANNEL_2 (2) /* analog input 2 */ > > -#define AD7923_CHANNEL_3 (3) /* analog input 3 */ > > The fact that is not used, is not a problem really. > This can serve as a "shortcut" for the datasheet. In some cases I would agree, but here adding a definition to go from a channel number in text to an actual number doesn't add anything. If there mapping was more complex then it would be reasonable to have defines, but here I can't see the point. So let's keep the patch to drop them. I'll pick it up whilst the comments on patch 4 have been addressed. Thanks, Jonathan > > We can leave this as-is [1], or remove it as you do [2], or an alternative > would be [3]: > #define AD7923_CHANNEL(x) (x) /* analog channel input */ > > I don't mind either of these 3 versions ([1], [2] or [3]). > > I'll leave it to Jonathan's preference. > > > #define AD7923_SEQUENCE_OFF (0) /* no sequence fonction > > */ > > #define AD7923_SEQUENCE_PROTECT (2) /* no interrupt > > write cycle */ > > #define AD7923_SEQUENCE_ON (3) /* continuous sequence */
