Re: [PATCH] iio: adc: npcm: use devm_platform_ioremap_resource

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sun, 2019-10-13 at 16:44 +0100, jic23@xxxxxxxxxx wrote:
> From: Jonathan Cameron <Jonathan.Cameron@xxxxxxxxxx>
> 
> Reduces local boilerplate code.
> Suggested by coccinelle via coccicheck.
> 
> CHECK   drivers/iio/adc/npcm_adc.c
> drivers/iio/adc/npcm_adc.c:200:1-11: WARNING: Use
> devm_platform_ioremap_resource for info -> regs
> 

Reviewed-by: Alexandru Ardelean <alexandru.ardelean@xxxxxxxxxx>

> Signed-off-by: Jonathan Cameron <Jonathan.Cameron@xxxxxxxxxx>
> Cc: Tomer Maimon <tmaimon77@xxxxxxxxx>
> ---
>  drivers/iio/adc/npcm_adc.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/drivers/iio/adc/npcm_adc.c b/drivers/iio/adc/npcm_adc.c
> index 910f3585fa54..a6170a37ebe8 100644
> --- a/drivers/iio/adc/npcm_adc.c
> +++ b/drivers/iio/adc/npcm_adc.c
> @@ -183,7 +183,6 @@ static int npcm_adc_probe(struct platform_device
> *pdev)
>  	int irq;
>  	u32 div;
>  	u32 reg_con;
> -	struct resource *res;
>  	struct npcm_adc *info;
>  	struct iio_dev *indio_dev;
>  	struct device *dev = &pdev->dev;
> @@ -196,8 +195,7 @@ static int npcm_adc_probe(struct platform_device
> *pdev)
>  
>  	info->dev = &pdev->dev;
>  
> -	res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> -	info->regs = devm_ioremap_resource(&pdev->dev, res);
> +	info->regs = devm_platform_ioremap_resource(pdev, 0);
>  	if (IS_ERR(info->regs))
>  		return PTR_ERR(info->regs);
>  




[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Input]     [Linux Kernel]     [Linux SCSI]     [X.org]

  Powered by Linux